-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Runtime config API #1967
Comments
I suggest handling this via #514. All of the above settings are currently configurable (or will be with a few minor alterations) via the runtime system built into Envoy. If we had an easy to use admin API which allowed you to query/set runtime keys would that satisfy what you need? Then you could hit the local API via an interceptor. |
@mattklein123 whatever you think ... I only raised this issue because you had suggested it. |
@nmittler I'm asking if the above solution will satisfy you. :) |
@mattklein123 yeah AFAIK that should work |
OK I'm going to resolve this in favor of #514 as that will solve your issue and is already open. |
@mattklein123 SGTM, thanks! |
* Add support for TCP local attributes * linter fixes * review comments
Title: Add Runtime config API
Description:
As part of some ongoing work in Istio to support Spring Boot applications using Hystrix circuit breakers, there is a desire to allow the application to override the circuit breaking configuration of it's Envoy instance.
I think to be safe, we'd want to be able to change any of Istio's circuit breaker params:
Relevant Links:
Related Discussion
Istio's circuit breaker params
The text was updated successfully, but these errors were encountered: