Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Runtime config API #1967

Closed
nmittler opened this issue Oct 30, 2017 · 6 comments
Closed

Add Runtime config API #1967

nmittler opened this issue Oct 30, 2017 · 6 comments
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@nmittler
Copy link

Title: Add Runtime config API

Description:
As part of some ongoing work in Istio to support Spring Boot applications using Hystrix circuit breakers, there is a desire to allow the application to override the circuit breaking configuration of it's Envoy instance.

I think to be safe, we'd want to be able to change any of Istio's circuit breaker params:

  • cluster.MaxRequestsPerConnection
  • cluster.CircuitBreaker.Default.MaxConnections
  • cluster.CircuitBreaker.Default.MaxRequests
  • cluster.CircuitBreaker.Default.MaxPendingRequests
  • cluster.OutlierDetection.MaxEjectionPercent
  • cluster.OutlierDetection.BaseEjectionTimeMS
  • cluster.OutlierDetection.ConsecutiveErrors
  • cluster.OutlierDetection.IntervalMS
  • cluster.OutlierDetection.MaxEjectionPercent

Relevant Links:
Related Discussion
Istio's circuit breaker params

@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Oct 30, 2017
@mattklein123
Copy link
Member

I suggest handling this via #514. All of the above settings are currently configurable (or will be with a few minor alterations) via the runtime system built into Envoy. If we had an easy to use admin API which allowed you to query/set runtime keys would that satisfy what you need? Then you could hit the local API via an interceptor.

@nmittler
Copy link
Author

@mattklein123 whatever you think ... I only raised this issue because you had suggested it.

@mattklein123
Copy link
Member

@nmittler I'm asking if the above solution will satisfy you. :)

@nmittler
Copy link
Author

@mattklein123 yeah AFAIK that should work

@mattklein123
Copy link
Member

OK I'm going to resolve this in favor of #514 as that will solve your issue and is already open.

@nmittler
Copy link
Author

@mattklein123 SGTM, thanks!

rshriram pushed a commit to rshriram/envoy that referenced this issue Oct 30, 2018
* Add support for TCP local attributes

* linter fixes

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

2 participants