Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: add admin endpoint to view/modify loaded values #514

Closed
mattklein123 opened this issue Feb 27, 2017 · 7 comments
Closed

runtime: add admin endpoint to view/modify loaded values #514

mattklein123 opened this issue Feb 27, 2017 · 7 comments
Assignees
@jsedgwick
Labels
beginner Good starter issues! enhancement Feature requests. Not bugs or questions.
Milestone
1.7.0

Comments

@mattklein123
Copy link
Member

Will be generally useful to have admin endpoint to:

  • list/view loaded values
  • modify/add values (this will need to trigger a reload just like inotify, and can probably be implemented as an additional override layer).
@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Feb 27, 2017
@mattklein123 mattklein123 added the help wanted Needs help! label Jul 12, 2017
@mattklein123 mattklein123 added the beginner Good starter issues! label Oct 28, 2017
@mattklein123 mattklein123 mentioned this issue Oct 30, 2017
Closed
@mattklein123 mattklein123 added this to the 1.6.0 milestone Nov 26, 2017
@nmittler nmittler mentioned this issue Dec 8, 2017
Closed
@mattklein123
Copy link
Member Author

@rodaine this is a good ramp up issue for you. Let's chat offline.

@mattklein123 mattklein123 removed the help wanted Needs help! label Dec 12, 2017
@rodaine rodaine mentioned this issue Jan 4, 2018
Merged
@rodaine rodaine mentioned this issue Jan 12, 2018
Merged
@mattklein123 mattklein123 modified the milestones: 1.6.0, 1.7.0 Mar 5, 2018
@jsedgwick
Copy link

@mattklein123 do we still want to do the write side of this now in light of #2763?

@mattklein123
Copy link
Member Author

@jsedgwick yes we should still do this. Security is orthogonal.

@mattklein123
Copy link
Member Author

(Though the modification endpoint should be a POST)

@jsedgwick
Copy link

@mattklein123 should you be able to add/modify runtime values if there is no backing on-disk runtime set up (and therefore the default runtime is empty)? I don't know enough about how this feature is used to determine whether that would be a useful capability or not.

@mattklein123
Copy link
Member Author

Optimally, having this available also for the "null" runtime impl would be nice, as people could override settings for testing even without using the full disk version.

@jsedgwick
Copy link

Yeah, sounds right. Will do.

@jsedgwick jsedgwick mentioned this issue Mar 16, 2018
Merged
mandarjog pushed a commit to mandarjog/envoy that referenced this issue May 15, 2020
@TristonianJones @mandarjog
Upgrade to cel-cpp v0.2.0 to pick up ANTLR thread-safety changes. (en…
8f8da11 
…voyproxy#514)

* Upgrade to cel-cpp v0.2.0 to pick up ANTLR thread-safety changes.

Signed-off-by: Tristan Swadell <[email protected]>
istio-testing pushed a commit to istio/envoy that referenced this issue May 18, 2020
@mandarjog @TristonianJones
[release-1.6] Update cel-cpp to fix CEL seg fault (#217)
ebac37f 
* Upgrade to cel-cpp v0.2.0 to pick up ANTLR thread-safety changes. (envoyproxy#514)

* Upgrade to cel-cpp v0.2.0 to pick up ANTLR thread-safety changes.

Signed-off-by: Tristan Swadell <[email protected]>

* emit error if an error value is returned (envoyproxy#511)

Signed-off-by: Mandar Jog <[email protected]>

Co-authored-by: Tristan Swadell <[email protected]>
lizan pushed a commit to lizan/envoy that referenced this issue Jun 4, 2020
@TristonianJones
Upgrade to cel-cpp v0.2.0 to pick up ANTLR thread-safety changes. (en…
9250112 
…voyproxy#514)

* Upgrade to cel-cpp v0.2.0 to pick up ANTLR thread-safety changes.

Signed-off-by: Tristan Swadell <[email protected]>
jpsim pushed a commit that referenced this issue Nov 28, 2022
@junr03 @jpsim
android: wire up on trailers (#514)
cefea43 
Description: this PR wires up on trailers callback for android, which was previously missing.
Risk Level: low - using already battled tested code paths for accumulating headers.
Testing: pending testing with gRPC on the Lyft android app

Fixes #506

Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@junr03 @jpsim
android: wire up on trailers (#514)
0b57e34 
Description: this PR wires up on trailers callback for android, which was previously missing.
Risk Level: low - using already battled tested code paths for accumulating headers.
Testing: pending testing with gRPC on the Lyft android app

Fixes #506

Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsedgwick jsedgwick

Labels
beginner Good starter issues! enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
3 participants
@jsedgwick @rodaine @mattklein123