http: making the admission control filter a dual filter #23071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
admission_control
branch
from
c78ac96 to
f691061
Compare
|
Hey @phlax can you look at this vs prior push: one failed format due to flags errors and the other succeeded |
alyssawilk
force-pushed
the
admission_control
branch
from
64ca071 to
8469d6d
Compare
Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
force-pushed
the
admission_control
branch
from
8469d6d to
de4f68e
Compare
wbpcode
reviewed
Sep 14, 2022
|
Awesome. I had no idea that upstream filters would move so fast. 👍 Thank you so much. |
|
/wait on other PR |
alyssawilk
added a commit
that referenced
this pull request
Sep 14, 2022
https://github.com/envoyproxy/envoy/blob/main/source/docs/upstream_filters.md calls out how to convert filters to dual filters and notes that init_manager and stats must come from DualInfo This pr actually adds stats to DualInfo for use in #23071 and updates docs for filter conversion Risk Level: low Testing: updated unit test Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
pianiststickman
added a commit
to pianiststickman/envoy
that referenced
this pull request
Aug 21, 2023
This is a revival of envoyproxy#25535 with changes for previous review comments. Risk level: low Testing: integration tested Docs changes: n/a Release notes: makes the ext_authz filter a dual filter. See also: envoyproxy#23071 (model), envoyproxy#10455 Signed-off-by: Eugene Chan <[email protected]>
alyssawilk
pushed a commit
that referenced
this pull request
Sep 18, 2023
This is a revival of #25535 with changes for previous review comments. Risk level: low Testing: integration tested Docs changes: n/a Release notes: makes the ext_authz filter a dual filter. See also: #23071 (model), #10455 Signed-off-by: Eugene Chan <[email protected]> Signed-off-by: pianiststickman <[email protected]> Co-authored-by: Greg Greenway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: integration tested
Docs Changes: n/a
Release Notes: inline
Part of #10455