-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream: stats scope for dual filters #23103
Conversation
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
I'm also going to update the docs in this PR, so the other is a clean example and doesn't include spurious files. |
Please resolve the conflict in the docs. Thanks. |
And a minor spelling error in doc:
non-cost -> non-const |
And could you check following snippet of doc:
Seems it lost something like And if |
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
https://github.com/envoyproxy/envoy/blob/main/source/docs/upstream_filters.md calls out how to convert filters to dual filters and notes that init_manager and stats must come from DualInfo
This pr actually adds stats to DualInfo for use in #23071 and updates docs for filter conversion
Risk Level: low
Testing: updated unit test
Docs Changes: n/a
Release Notes: n/a