-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readd some privacy #712
readd some privacy #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing PR, thanks so much. looks so much cleaner now and will be much easier to extend in the future. well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The codebase is getting cleaner and cleaner
7a3eb50
to
7730c4a
Compare
7730c4a
to
92e4118
Compare
readding what was called differential privacy which is quite a bit harder to implement correctly (we need to know the variability of every features for one, and have a dedicated paper-based way to implement it, see #613).
I got lost along the way and changed more things, oupsi
privacy
module, withaddNoise
andclipNorm
doing what was doing goo'old DPTrainingInformation.privacy
DistributedTrainer
,LocalTrainer
,TrainerBuilder
into a simple non-abstractTrainer
discojs.Disco
to a more straightfoward objectTrainer
and notLogger
,Task
and othersAggregator
to a real event emittermakeResult
,receiveResult
👀)Model
link, everything goes through events nowAsyncInformant