Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for pickletensor models to F5-TTS #475

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

SilyNoMeta
Copy link

Only safetensors models are detected by default, while pickletensor files seems to work decently just by scanning them.

Tested against @RASPAUDIO french model available here : https://huggingface.co/RASPIAUDIO/F5-French-MixedSpeakers-reduced, who do not provide safetensors files.

@erew123
Copy link
Owner

erew123 commented Jan 5, 2025

Hi @SilyNoMeta

Happy new year! I see youve submitted quite a few PR's, thanks for getting involved! Im going to be working my way through a backlog of issues tickets and PR's so it will take me a while to do that, depending on my availability.

Re pickle files, I have no issue in principle, however do you think it may be good to print a warning out at the console when a pickle file is being loaded, just to say that it could be dangerous and to do so at your own risk. Perhaps we could link to this https://huggingface.co/docs/hub/en/security-pickle

Perhaps even a link to something like this https://huggingface.co/spaces/safetensors/convert

As I say, working my way through lots of other tickets/PS's so will be looking at the others sometime soon.

Thanks

@SilyNoMeta
Copy link
Author

Hi @erew123
Happy new year to you too 🎆

No, you're right, pickles are not really a priority ! Especially when you look at the huggingface article.
I will probably rework the conditions on my fork so that it loads pickles after safetensors and log a warning as you said, but I don't want to open the pandora's box on your project, so you might just close this PR.

Don't worry about the others PRs, they are not going anywhere so take your time, I might even add some 😄 (but I'm really getting close to a it's enough for my project needs so I will naturally slow down)

@erew123
Copy link
Owner

erew123 commented Jan 6, 2025

Hey @SilyNoMeta Thanks for adding the warning in. Im happy enough to pull this in, but may leave it undocumented until I get round to a later PR and probably update some documentation.

Thanks

@erew123 erew123 merged commit fe41105 into erew123:alltalkbeta Jan 6, 2025
@SilyNoMeta
Copy link
Author

No problem 😄

@SilyNoMeta SilyNoMeta deleted the feat/f5-pickletensor branch January 6, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants