Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for pickletensor models to F5-TTS #475

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Add initial support for pickletensor models to F5-TTS #475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e72a7bf
Add initial support for pickletensor models to F5-TTS
SilyNoMeta Jan 3, 2025
0182e8f
Add a warning when a pickle file is loaded
SilyNoMeta Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions system/tts_engines/f5tts/model_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,12 +403,19 @@ def scan_models_folder(self):
if not model_files:
# If no model_*.safetensors found, try any .safetensors file
model_files = list(model_dir.glob("*.safetensors"))

if not model_files:
# Try finding a pt model file as fallback
# If no model_*.safetensors found, try finding a .pt model file
model_files = list(model_dir.glob("model_*.pt"))
if not model_files:
# If no model_*.safetensors found, try any .pt file
model_files = list(model_dir.glob("*.pt"))

vocab_file = model_dir / "vocab.txt"
vocos_dir = model_dir / "vocos"
vocos_config = vocos_dir / "config.yaml"
vocos_model = vocos_dir / "pytorch_model.bin"

# Check if we have at least one model file and all other required files
if model_files and all(f.exists() for f in [vocab_file, vocos_config, vocos_model]):
model_name = model_dir.name
Expand Down Expand Up @@ -506,11 +513,28 @@ async def api_manual_load_model(self, model_name):
vocab_path = model_dir / "vocab.txt"
vocos_path = model_dir / "vocos"

# Dynamically find the safetensors model file
# Dynamically find the safetensors or pickletensor model file
model_is_pickle = False
model_files = list(model_dir.glob("model_*.safetensors"))
if not model_files:
# Try finding any safetensors file as fallback
model_files = list(model_dir.glob("*.safetensors"))
if not model_files:
# Try finding the pt model file as fallback
model_files = list(model_dir.glob("model_*.pt"))
model_is_pickle = True
if not model_files:
# Try finding any pt file as fallback
model_files = list(model_dir.glob("*.pt"))
model_is_pickle = True

if model_is_pickle:
print(
f"[{self.branding}ENG] \033[91mWarning\033[0m: The models found in '{model_dir}' are in Pickle format (.pt). "
f"This format poses security risks due to potential arbitrary code execution. "
f"Please ensure the source of the models is trusted. We recommend using 'safetensors' format for enhanced security. "
f"For more information, visit: https://huggingface.co/docs/hub/en/security-pickle"
)

if not model_files:
print(f"[{self.branding}ENG] \033[91mError\033[0m: No model's safetensors file was found in the F5-TTS models directory.")
Expand Down