fix(tests): Fixing add_users smoke test (datahub-project#7116)

ericyomi · Feb 8, 2023 · 9b19168 · 9b19168
1 parent bf28db5
commit 9b19168
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/datahub-web-react/src/app/shared/ManageAccount.tsx b/datahub-web-react/src/app/shared/ManageAccount.tsx
@@ -103,7 +103,7 @@ export const ManageAccount = ({ urn: _urn, pictureLink: _pictureLink, name }: Pr
             </MenuItem>
             <Menu.Divider />
             <MenuItem danger key="logout" tabIndex={0}>
-                <a href="/logOut" onClick={handleLogout}>
+                <a href="/logOut" onClick={handleLogout} data-testid="log-out-menu-item">
                     Sign Out
                 </a>
             </MenuItem>
@@ -112,7 +112,7 @@ export const ManageAccount = ({ urn: _urn, pictureLink: _pictureLink, name }: Pr
 
     return (
         <Dropdown overlay={menu} trigger={['click']}>
-            <DropdownWrapper>
+            <DropdownWrapper data-testid="manage-account-menu">
                 <CustomAvatar photoUrl={_pictureLink} style={{ marginRight: 4 }} name={name} />
                 <DownArrow />
             </DropdownWrapper>

diff --git a/smoke-test/tests/cypress/cypress/integration/mutations/add_users.js b/smoke-test/tests/cypress/cypress/integration/mutations/add_users.js
@@ -25,6 +25,7 @@ describe("add_user", () => {
         cy.waitTextVisible(/signup\?invite_token=\w+/).then(($elem) => {
             const inviteLink = $elem.text();
             cy.log(inviteLink);
+            cy.visit("/settings/identities/users");
             cy.logout();
             cy.visit(inviteLink);
             let name = tryToSignUp();

diff --git a/smoke-test/tests/cypress/cypress/support/commands.js b/smoke-test/tests/cypress/cypress/support/commands.js
@@ -37,7 +37,8 @@ Cypress.Commands.add('deleteUrn', (urn) => {
 })
 
 Cypress.Commands.add("logout", () => {
-  cy.visit("/logOut")
+  cy.get(selectorWithtestId("manage-account-menu")).click();
+  cy.get(selectorWithtestId("log-out-menu-item")).click({ force: true });
   cy.waitTextVisible("Username");
   cy.waitTextVisible("Password");
 });