-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Loading status checks…
polygon/p2p: fix p2p fetcher peer errors on chain tip (#11927)
More issues surfaced on chain tip when testing astrid: 1. context deadline exceeded when requesting new block event at tip from peer - can happen, safe to ignore event and continue instead of crashing: ``` [EROR] [09-06|03:41:00.183] [2/6 PolygonSync] stopping node err="await *eth.BlockHeadersPacket66 response interrupted: context deadline exceeded" ``` 2. Noticed we do not penalise peers for penalize-able errors when calling `FetchBlocks` - added that in 3. We got another error that crashed the process - `ErrNonSequentialHeaderNumbers` - it is safe to ignore new block event if this happens and continue ``` EROR[09-05|20:26:35.141] [2/6 PolygonSync] stopping node err="non sequential header numbers in fetch headers response: current=11608859, expected=11608860" ``` 4. Added all other p2p errors that may happen and are safe to ignore at tip event processing 5. Added debug logging for better visibility into chain tip events 6. Fixed missing check for whether we have already processed a new block event (ie if its hash is already contained in the canonical chain builder)
Showing
4 changed files
with
284 additions
and
114 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters