Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polygon/p2p: fix p2p fetcher peer errors on chain tip #11927

Merged
merged 11 commits into from
Sep 10, 2024

Conversation

taratorio
Copy link
Member

@taratorio taratorio commented Sep 9, 2024

More issues surfaced on chain tip when testing astrid:

  1. context deadline exceeded when requesting new block event at tip from peer - can happen, safe to ignore event and continue instead of crashing:
[EROR] [09-06|03:41:00.183] [2/6 PolygonSync] stopping node          err="await *eth.BlockHeadersPacket66 response interrupted: context deadline exceeded"
  1. Noticed we do not penalise peers for penalize-able errors when calling FetchBlocks - added that in
  2. We got another error that crashed the process - ErrNonSequentialHeaderNumbers - it is safe to ignore new block event if this happens and continue
EROR[09-05|20:26:35.141] [2/6 PolygonSync] stopping node          err="non sequential header numbers in fetch headers response: current=11608859, expected=11608860"
  1. Added all other p2p errors that may happen and are safe to ignore at tip event processing
  2. Added debug logging for better visibility into chain tip events
  3. Fixed missing check for whether we have already processed a new block event (ie if its hash is already contained in the canonical chain builder)

@taratorio taratorio marked this pull request as ready for review September 10, 2024 07:41
@taratorio taratorio enabled auto-merge (squash) September 10, 2024 12:05
@taratorio taratorio merged commit 4acd212 into main Sep 10, 2024
10 checks passed
@taratorio taratorio deleted the astrid-more-ignoreable-peer-errs-on-tip-events branch September 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants