Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(espp-rtsp): use espp::RtspClient #3

Merged
merged 1 commit into from
May 6, 2023
Merged

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented May 6, 2023

Description

  • Moved RtspClient into espp submodule and use that
  • Updated main code accordingly

Motivation and Context

Using the submodule helps ensure the client and server stay in sync as changes come.

How has this been tested?

Building and running the main code. See also esp-cpp/espp#58

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2023-05-06 at 10 27 21@2x

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Moved RtspClient into espp submodule and use that
* Updated main code accordingly
@finger563 finger563 added the enhancement New feature or request label May 6, 2023
@finger563 finger563 merged commit aa17213 into main May 6, 2023
@finger563 finger563 deleted the feature/espp-rtsp branch May 6, 2023 04:54
@finger563 finger563 mentioned this pull request May 6, 2023
12 tasks
@finger563
Copy link
Contributor Author

Related to #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant