Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rtsp #58

Merged
merged 6 commits into from
May 6, 2023
Merged

Feature/rtsp #58

merged 6 commits into from
May 6, 2023

Conversation

finger563
Copy link
Contributor

@finger563 finger563 commented May 6, 2023

Description

  • Added rtsp component with rtsp_client (copied from esp-cpp/camera-display) and new rtsp_server
  • Added example for showing rtsp_server
  • Added python code with two different implementations (one uses opencv rtsp client functionality, the other is custom implementation)
  • Added python code for showing raw jpeg data
  • Allow configuration of packetization parameter for the rtsp_server since the original (1500) was too large for the esp32 camera-display to receive properly
  • Make sure client uses new socket interface
  • Update config for the client sockets
  • Updated initialization for the rtp packet.
  • Updated rtsp example code to have RtspClient example
  • Updated rtsp client to have more coplete docs
  • Update and rebuild docs
  • update ci

Motivation and Context

camera-streamer and camera-display Make use of them, so consolidating into a single library helps ensure the client and server always interoperate. Additionally, it provides another use case for the socket library to help validate its usability.

How has this been tested?

Running the code in the repos above, see the video below.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Example showing the server (camera), the client (handheld display), and the python client, with both clients connected simultaneously:

rtsp_client_server_compressed.mp4

Screenshot showing the server running for a very long time (all day, see timestamp in log > 33,000 seconds):
all_day_test

Screenshot showing the received framerate on the camera-display:
CleanShot 2023-05-06 at 10 27 21@2x

Screenshot of main code for camera-streamer output:
CleanShot 2023-05-06 at 10 29 31@2x

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

finger563 added 6 commits May 5, 2023 22:13
* Added rtsp component with rtsp_client (copied from esp-cpp/camera-display) and new rtsp_server
* Added example for showing rtsp_server
* Added python code with two different implementations (one uses opencv rtsp client functionality, the other is custom implementation)
* Added python code for showing raw jpeg data
* Allow configuration of packetization parameter for the rtsp_server since the original (1500) was too large for the esp32 camera-display to receive properly
* Make sure client uses new socket interface
* Update config for the client sockets
* Updated initialization for the rtp packet.
* Updated rtsp example code to have RtspClient example
* Updated rtsp client to have more coplete docs
@finger563 finger563 added rtsp enhancement New feature or request labels May 6, 2023
@finger563 finger563 merged commit 13e6595 into main May 6, 2023
@finger563 finger563 deleted the feature/rtsp branch May 6, 2023 04:47
@finger563
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rtsp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant