Removing unnecessary bitfield from I2C driver
#1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
reviewed
Aug 2, 2024
There was a problem hiding this comment.
Changes LGTM! Might be worth to convert it to draft until esp-rs/esp-pacs#261 is merged and pacs are updated.
SergioGasquez
approved these changes
Aug 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AnthonyGrondin
pushed a commit
to AnthonyGrondin/esp-hal
that referenced
this pull request
Aug 8, 2024
* Getting rid of bitfield usage fmt * use `variant` methods for opcode * update pacs dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
closes #1751.
REQUIRES esp-rs/esp-pacs#261 to be merged!!!
Testing
Executed
i2c-related examples. The outputs are completely the same as before this change