Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split COMMAND register for I2C #261

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Split COMMAND register for I2C #261

merged 2 commits into from
Aug 7, 2024

Conversation

playfulFence
Copy link
Contributor

Satisfying the esp-rs/esp-hal#1751

jessebraham
jessebraham reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a handful of comments.

esp32/svd/patches/esp32.yaml Show resolved Hide resolved
esp32h2/svd/patches/esp32h2.yaml Show resolved Hide resolved
esp32p4/svd/patches/esp32p4.yaml Show resolved Hide resolved
esp32s2/svd/patches/esp32s2.yaml Show resolved Hide resolved
esp32s3/svd/patches/esp32s3.yaml Show resolved Hide resolved
common_patches/i2c0.yaml Outdated Show resolved Hide resolved
burrbull
burrbull reviewed Jul 16, 2024
View reviewed changes
common_patches/i2c0.yaml Outdated Show resolved Hide resolved
burrbull
burrbull reviewed Jul 16, 2024
View reviewed changes
common_patches/i2c0.yaml Outdated Show resolved Hide resolved
@Dominaezzz
Copy link

The -ulp and -lp pacs have this register too btw

@playfulFence playfulFence mentioned this pull request Aug 2, 2024
Merged
5 tasks
@playfulFence
Copy link
Contributor Author

The -ulp and -lp pacs have this register too btw

  • yes, but initially this PR was created to resolve the issue on non-LP chips.

And honestly, tried to do it, but the way the LP I2C peripherals were previously patched makes me personally some problems with making these changes for them. If we ever need to do this at some point - I'll get back to it, no problem.

MabezDev
MabezDev approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MabezDev MabezDev merged commit 27dd7e5 into esp-rs:main Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull left review comments

@jessebraham jessebraham jessebraham left review comments

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@playfulFence @Dominaezzz @jessebraham @burrbull @MabezDev