Use flash_mode for memory_type when memory_type is not set for …
#7141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ESP32, C3 and S2
|
Thanks @Jason2866 for the PR! @ivankravets Can you please help with the review? |
|
Ahh, i just noticed the entrys are generated here So this PR is not really the solution |
|
Replaced by espressif/esp32-arduino-lib-builder#80 |
|
Closing since espressif/esp32-arduino-lib-builder#80 it is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ESP32, C3 and S2 when using Platformio
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Without this change always the lib from path "tools", "sdk", "esp32", "qio_qspi" is included for ESP32, C3 and S2
The PR uses for memory_mode the setting from
flash_mode. There are no other memory_modes for this devices.The behaviour for S3 is not changed since it needs a correct set
memory_typeto work.Related links
Solves platformio/platform-espressif32#877
(eg. Closes #number of issue)