Use flash_mode for memory_type when memory_type is not set for #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ESP32, C3 and S2 when using Platformio
Closed
4 tasks
|
This change is tested and verified. Builded framework is working |
This was referenced Aug 16, 2022
|
Can you please replace |
|
@me-no-dev Changed. I always thought |
it is, but it is unnecessary on boards other than one very specific ESP32 based one. So to save on libs and bootloaders, it has been removed on S3 and probably will do for C3 and S2 in the future. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ESP32, C3 and S2 when using Platformio
Replaces espressif/arduino-esp32#7141