Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when is the next release? #10083

Closed
h8liu opened this issue Sep 11, 2018 · 7 comments
Closed

when is the next release? #10083

h8liu opened this issue Sep 11, 2018 · 7 comments
Assignees

Comments

@h8liu
Copy link

h8liu commented Sep 11, 2018

people are starting to use go modules, but can only use a release before the import path has changed. This has caused incompatibility between go get with modules enabled or not.

See google/go-cloud#429 for background.

Is there planning/timeline for a release 4.0.0 (because import path change is not backward compatible now)?

@gyuho
Copy link
Contributor

gyuho commented Sep 11, 2018

Yeah for v3.4, I will soon switch to go module. Already tried it and works well for etcd.

@gyuho gyuho self-assigned this Sep 11, 2018
@h8liu
Copy link
Author

h8liu commented Sep 12, 2018

note that, based on semver spec, after the import path change to go.etcd.io/etcd, the version number probably, needs to be 4.0

@gyuho
Copy link
Contributor

gyuho commented Sep 12, 2018

@h8liu I don't think we need bump up major version? It's only import path change, no API change was made.

@h8liu
Copy link
Author

h8liu commented Sep 13, 2018

because of the import path change, previous code that imports "github.com/coreos/etcd" won't be able to use the code without change. For example:

https://gopkgs.io/builds/20180911-195307-3d66b81f

unless you treat it a completely different package.. where the new version number does not matter.

@xiang90
Copy link
Contributor

xiang90 commented Sep 13, 2018

@h8liu

The etcd version is not going to get bumped. etcd is a binary program not a library. We have been talking about how to separate the client library versioning from the etcd binary versioning, but have not found a good way to do it.

@wenjiaswe
Copy link
Contributor

cc @jpbetz

@h8liu
Copy link
Author

h8liu commented Sep 13, 2018

@xiang90 Thanks for explaining. Then it is wrong for go-cloud (or any repo that uses go mod from 1.11) to reference the version in its go.mod or go.sum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants