Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtimevar/etcd: import go.etcd.io/etcd instead of github.com/coreos/etcd #429

Closed
vangent opened this issue Sep 11, 2018 · 8 comments
Closed
Assignees
Labels
blocked Blocked on a different issue
Milestone

Comments

@vangent
Copy link
Contributor

vangent commented Sep 11, 2018

github.com/coreos/etcd has renamed to use package name go.etcd.io/etcd. They are two different packages, and hence some of the packages stops working with go get. could you change to import go.etcd.io/etcd? Thanks.

@vangent
Copy link
Contributor Author

vangent commented Sep 11, 2018

(filing for @h8liu based on a comment on a pr)

@vangent
Copy link
Contributor Author

vangent commented Sep 11, 2018

Per @h8liu

Here is an example of build failure trying to build the etcd repo with github.com/coreos/etcd import path:

https://gopkgs.io/builds/20180911-195307-3d66b81f

@h8liu
Copy link
Contributor

h8liu commented Sep 11, 2018

the current downside is that etcd has not officially released a version after they changed the import path.. so to support go get, one has to use one that is not compatible with their latest release.

@h8liu
Copy link
Contributor

h8liu commented Sep 11, 2018

importing as go.etcd.io/etcd still builds, but will drag in github.com/coreos/etcd because the source is pre-import-path-change.

@vangent
Copy link
Contributor Author

vangent commented Sep 11, 2018

Yea, I did try to use go.etcd.io/etcd at first, but it keeps pulling in the old coreos/etcd as well, and then I get compatibility errors:

unknown field 'NoFreelistSync' in struct literal of type bolt.Options

master...vangent:etcd-rename shows the go.mod changes that result.

I think we'd prefer to wait until there's an official etcd release with the new name, then we can switch to use it.

@vangent vangent added the blocked Blocked on a different issue label Sep 11, 2018
@vangent vangent added this to the Sprint 17 milestone Sep 11, 2018
@vangent
Copy link
Contributor Author

vangent commented Sep 11, 2018

Blocked on a version after 3.3.9:
https://github.com/etcd-io/etcd/releases

@vangent
Copy link
Contributor Author

vangent commented Oct 10, 2018

I tried again with 3.3.10, but got the same problems with coreos things getting pulled in.

@zombiezen zombiezen modified the milestones: Sprint 18, Unplanned Oct 17, 2018
@PatrickHuang888
Copy link

I tried go.etcd.io/etcd v3.3.10+incompatible // indirect got error

unknown field 'NoFreelistSync' in struct literal of type bolt.Options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on a different issue
Projects
None yet
Development

No branches or pull requests

4 participants