using go.etcd.io/etcd for etcd import path

[h8liu]

for #429

[h8liu]

interesting that your ci is using an internal GOPROXY? is it managed by your team?

[vangent]

interesting that your ci is using an internal GOPROXY? is it managed by your team?

Yup.

[vangent]

It seems very odd to include 2 separate versions of etcd. Any objection to waiting with this change until there's a new etcd release with the new names?

[h8liu]

sure, np. I filed etcd-io/etcd#10083 to query about their schedules.

[gyuho]

Hi, we are switching to go module in master branch soon. But, maybe not in release branches. Do you need us use go module for release branch as well?

[h8liu]

(I am actually not a member of go-cloud)

so quoting from:

etcd-io/etcd#10083

etcd is a binary program not a library. We have been talking about how to separate the client library versioning from the etcd binary versioning, but have not found a good way to do it.

I got this reply when I asked them to bump the version to 4.0.0 because import path change is not backward compatible. They refused because their version number is for the binary, not for the source code (client api). As a result, using release tags from the etcd git repo in go mod is probably incorrect.

[vangent]

Can we close this PR and revisit once etcd has done a new release with the new paths (whatever they end up tagging it)?

[h8liu]

sure, whatever.

again, no matter what version they use, it is not for go module import. the version is for the binary not the library.