Windows build fix and makefile update #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
soc1c,
noot,
dziabko,
GregTheGreek and
steviezhang
austinabell
added
ISS: Duplicate
steviezhang
previously approved these changes
Aug 22, 2019
|
nvm the CI is still broken for windows and mac since it uses a linux machine to build and is failing on building non-linux cgo it seems Edit: Yeah you can cross compile go using the flags but can't cross compile cgo, looking into a workaround now |
austinabell
force-pushed
the
austin/windowsbuild
branch
from
f298805 to
45dd611
Compare
austinabell
changed the title
soc1c
reviewed
Aug 29, 2019
soc1c
reviewed
Sep 2, 2019
| @@ -82,6 +190,14 @@ workflows: | |||
| filters: | |||
| tags: | |||
| only: /.*/ | |||
| # - build-darwin-go-1.12: | |||
There was a problem hiding this comment.
because on this linux VM in the CI cannot cross compile the darwin build because of CGO in Ethash. There is potentially an inconsistent and tedious workaround to use a mac VM through CircleCI and configure go but I would argue against it because Ethash should be migrated over and the build for linux and darwin are basically identical and tested locally.
The windows and mac build will be able to be uncommented and functional once Ethash is migrated from c to go
GregTheGreek
approved these changes
Sep 3, 2019
GregTheGreek
approved these changes
Sep 20, 2019
steviezhang
approved these changes
Sep 20, 2019
soc1c
pushed a commit
that referenced
this pull request
Oct 5, 2019
* Makefile: allow building windows binaries * circleci/config: add windows build and release steps * Makefile: allow building macos binaries * circleci/config: add darwin build and release steps * Fixed for windows * Remove default env variable and update chainconfig * Fix circliCI build * Added back platform specific building assume will be needed for release binary gen * Updated CI to use mac build * Remove cross compiling from CI workflow, refactored makefile * Changed binary compression to zip for windows
soc1c
added a commit
that referenced
this pull request
Oct 21, 2019
* updated TestParseNode to work with go v1.12.8 (#42) * Closes #46 update mainnet bootnodes list (#45) * Windows build fix and makefile update (#48) * Makefile: allow building windows binaries * circleci/config: add windows build and release steps * Makefile: allow building macos binaries * circleci/config: add darwin build and release steps * Fixed for windows * Remove default env variable and update chainconfig * Fix circliCI build * Added back platform specific building assume will be needed for release binary gen * Updated CI to use mac build * Remove cross compiling from CI workflow, refactored makefile * Changed binary compression to zip for windows * ecrecover edge case chains fix (#58) * Added edge case test and refactored logic * Wip specific tests still failing * Update invalid tests to use actual invalid chainid @austinabell made this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross compiles and sets up release binary generation, set up by @soc1c and I just changed it a bit to fix the CI for mac and windows and fixed a dependency to build on windows.
Also updates chainconfig from bootnodes update.
Note: chain config cannot be generated on windows as of now because of how the makefile is set up for that and I won't fix it yet since it's not relevant for who runs that command.