ecrecover edge case chains fix #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amerameen
approved these changes
Oct 5, 2019
noot
approved these changes
Oct 8, 2019
GregTheGreek
approved these changes
Oct 16, 2019
soc1c
pushed a commit
that referenced
this pull request
Oct 21, 2019
* Added edge case test and refactored logic * Wip specific tests still failing * Update invalid tests to use actual invalid chainid @austinabell made this change
soc1c
added a commit
that referenced
this pull request
Oct 21, 2019
* updated TestParseNode to work with go v1.12.8 (#42) * Closes #46 update mainnet bootnodes list (#45) * Windows build fix and makefile update (#48) * Makefile: allow building windows binaries * circleci/config: add windows build and release steps * Makefile: allow building macos binaries * circleci/config: add darwin build and release steps * Fixed for windows * Remove default env variable and update chainconfig * Fix circliCI build * Added back platform specific building assume will be needed for release binary gen * Updated CI to use mac build * Remove cross compiling from CI workflow, refactored makefile * Changed binary compression to zip for windows * ecrecover edge case chains fix (#58) * Added edge case test and refactored logic * Wip specific tests still failing * Update invalid tests to use actual invalid chainid @austinabell made this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone please fix the specific function testTests passing