Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.0 #2069

Merged
merged 2 commits into from
Mar 30, 2014
Merged

Release 1.4.0 #2069

merged 2 commits into from
Mar 30, 2014

Conversation

@JohnMcLear
Copy link
Member

o ho, noticed this doesn't have some bits in, need to update this :)

@JohnMcLear
Copy link
Member

Changelog and some fixes in, we can release at this point if you want or we can get the other bits done?

@marcelklehr
Copy link
Contributor Author

Tests tests tests, i'd say, but without testers...

Polish the styles of our docs a little
@Gared
Copy link
Member

Gared commented Mar 28, 2014

What about the timeslider fix? I would be really happy if we'll have a working timeslider in the next version.

@marcelklehr
Copy link
Contributor Author

@Gared please test 1.4.0-rc1 -- timeslider should work again

@Gared
Copy link
Member

Gared commented Mar 29, 2014

@marcelklehr Is this the timeslider refactoring from #2070?
Yes, It's working, but there are still a few bugs int it. See my comment #2070 (comment), but I'm happy so far with it. Thanks :-)
I will do further tests on this branch and give feedback.

@Gared
Copy link
Member

Gared commented Mar 29, 2014

I get the following javascript error, when opening "Import/Export" dialog and clicking somewhere else in the pad text:
ReferenceError: modules is not defined
if(module.css('display') != "none")
{
$("#" + modules[i] + "link").removeClass("selected"); // <---- Error is in this line
module.slideUp("fast", cb);
returned = true;
}

Can someone confirm this?

@JohnMcLear
Copy link
Member

Confirmed.

@JohnMcLear
Copy link
Member

Fixed and updated 1.4.0, please test.

@Gared
Copy link
Member

Gared commented Mar 29, 2014

@JohnMcLear Tested and fixed. Thanks.

@marcelklehr
Copy link
Contributor Author

Nope, we didn't merge #2070 in yet. 1.4 will still have the old timeslider.

@marcelklehr marcelklehr merged commit 54bf17b into master Mar 30, 2014
@rhansen rhansen deleted the release/1.4.0 branch February 15, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants