Timeslider++ #2070
Timeslider++ #2070
Conversation
This commit introduces a new TimesliderClient object which will
eventually handle all communication with the server in a sane fashion.
At the moment, minimal work has been done to wire the existing code into
this object. The current 'on("MESSAGE_TYPE")' model will change so that
the timeslider object is actually the one managing all the information,
instead of delegating it all out to callbacks.
This current version still works just as the stock version did.
The slider handle and stars render correctly. Not yet wired up to real events.
without this, the timeslider and sliderui classes don't work
Working slider class with mouse handling (click, drag) and events (change, slide). Lots of console logs still in the code. Got rid of some of the legacy code.
Also, the steppers actually work.
findPath works. transition requests changesets from server. processing of changesets works correctly. Only need to manage the async-ifying of transition, which is currently written as a while loop, (with a short-circuit break for debugging).
There are still some weird kinks in the traversal algorithm. For example, trying to go from 9 -> 19 fails very oddly.
There are still some bugs in the traversal algorithm, as well as bugs being triggered in the server. Also, for some reason it looks like there is a problem with the attribute pool not containing certain elements.
Working: - location.hash - click on slider - stepper buttons - UI update (except authors) Not working: - playback - bugs in transition code
|
There are (and have been for quite a while) some problems with the timeslider in the master branch. This (as well as #2040) is a complete re-implementation of the timeslider. All bugs mentioned in this thread refer to the version proposed here. ;) |
|
http://ricostacruz.com/nprogress/ might be nice to have since loading is apparently quite slow. |
|
I would very much appreciate some help right now. Please have a go at testing this everyone (use attributes like lists and stuff), and please help sort out why they're not displayed correctly. Thank you! |
|
Bug1) Revision 0 doesn't show the initial pad contents. To replicate:
Revision 0 is incorrect. Bug 2) Play doesn't work |
|
|
@marcelklehr the version 0 is still showing nothing. Why not just do an if content == "" show rev1 instead of rev0? |
|
/tests/frontend/?grep=timeslider_labels.js and /tests/frontend/?grep=timeslider_revisions.js fail -- I will sort these. |
|
There is no ability to export a given revision any more. There is no button to go back to the pad. Is this expected behavior @marcelklehr ? |
|
The test This with some work will be ready to merge :) |
|
@marcelklehr I rebased this so bugfixing for you should be easier :) |
|
the timeslider bar is gone now, is that intentional? Also, something's messing up the attributes, I can't wrap my head around this right now |
|
Yeah the bar gone is intentional until we figure out a good ui,ux |
|
Closing as it's been neglected.. I dunno if @marcelklehr wants to take this on again, doesn't seem that way! |
|
No, I won't be working on this. I'm sorry.
|
|
No worries :) |
These are my fixes for @s1341's new timeslider (see #2040).
The first commit essentially introduces a new path calculator that computes a path from one revision to a new one (early version of that here: https://gist.github.com/marcelklehr/8208237), the rest of the changes are collateral to this: I stripped out partialTransition for example and reduced some other parts, too.
My second commit addresses #2065 as well as the OccupyChar issue. I hope it doesn't cause any bugs, accidentally.
Lastly, there are still a few soar spots in the timeslider codez that should be addresses (e.g. try going from rev#36 to rev#25, i think), so.. NOT READY yet.
Update: see below...