fix timeslider not working because last changeset is not fetched #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The timeslider doesn't work for me with your patch... |
|
Where exactly did you find a similar check? |
|
On both latest develop and this pull request timeslider is completely broken for me |
Closed
|
Same for me - timeslider is broken: what could i do in v14 to make it work again? or is this just broken at all right now?!? |
|
Also tried the "patch" from Any hack, patch or other voodoo to make this work in 1.4.0 ? |
|
should be fixed in 1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I admit I have no understanding why the check is necessary. It seems like the condition is already checked earlier in program flow. But if the check is really necessary, it should at least be correct. This fixes the timeslider for now till the refractoring is done.