Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isthmus e2e test utils and withdrawal root fix #13933

Closed
wants to merge 1 commit into from

Conversation

meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jan 23, 2025

Description

Adds e2e test utils for Isthmus and fixes a bug where the WithdrawalRoot is not passed along between GetPayload and NewPayload which makes it impossible to build Isthmus blocks.

@meyer9 meyer9 requested review from a team as code owners January 23, 2025 02:19
@meyer9 meyer9 requested a review from protolambda January 23, 2025 02:19
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.67%. Comparing base (b8c011f) to head (4af4468).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
op-node/rollup/superchain.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13933      +/-   ##
===========================================
- Coverage    46.91%   46.67%   -0.24%     
===========================================
  Files          973      973              
  Lines        80957    80958       +1     
  Branches       770      770              
===========================================
- Hits         37979    37787     -192     
- Misses       40026    40260     +234     
+ Partials      2952     2911      -41     
Flag Coverage Δ
cannon-go-tests-32 61.99% <ø> (ø)
cannon-go-tests-64 56.62% <ø> (ø)
contracts-bedrock-tests 88.33% <ø> (-2.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-service/eth/types.go 30.73% <ø> (ø)
op-node/rollup/superchain.go 0.00% <0.00%> (ø)

... and 32 files with indirect coverage changes

@meyer9
Copy link
Contributor Author

meyer9 commented Jan 24, 2025

Closing in favor of #13973

@meyer9 meyer9 force-pushed the meyer9/isthmus-e2e-fixes branch from 4af4468 to 1383b3b Compare January 28, 2025 15:50
@meyer9 meyer9 closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant