-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-2537: Precompile for BLS12-381 curve operations #509
Comments
I took a swing at this one here: bluealloy/revm#2000 |
This needs:
Also warning: if I understood correctly from ACD calls, there are some G2mul precompiles of the BLS precompile set that were being removed, and still seem present in devnet 5, but not in final L1 Pectra scope, due to them being considered unnecessary/duplicate. We should not include these last-minute removed precompiles in L2. |
The removal of MUL precompiles, and pricing changes suggested in the ACD calls is implemented here in geth: ethereum/go-ethereum#30978 We'll need to pull this into op-geth once merged. |
We also need a performance analysis of any introduced precompiles to ensure that derivation is fault provable by cannon/op-program (and probably asterisc/kona too). Similar to the Cannon benchmarking performed by Base for the gas limit increase. It should answer questions like: Do BLS12-381 operations require too many steps to execute under cannon? How much memory is used by the VM in the worst case execution? |
@Inphi I believe we can utilize the L1 precompiles for this. The reason we needed to benchmark the |
Update on this work:
These are blocked by some fixes to get Isthmus/geth e2e tests working:
Planning on working on fault proofs accelerated precompile tests soon, and testing Reth precompiles as well later this week. |
pls add links in pm repo better, this is specs repo, and when spec is merged this issue will close, but doesn't mean implementation is done the issue doesn't exist, so please make a new one ethereum-optimism/pm#23 |
ah makes sense! I'll make an issue there |
https://eips.ethereum.org/EIPS/eip-2537
op-revm
op-geth
smart-contract
References
The text was updated successfully, but these errors were encountered: