Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/vm: implement EIP-2537 spec updates #30978

Merged
merged 13 commits into from
Jan 24, 2025
Merged

core/vm: implement EIP-2537 spec updates #30978

merged 13 commits into from
Jan 24, 2025

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jan 2, 2025

Reference:

@s1na s1na added the prague label Jan 2, 2025
@MariusVanDerWijden
Copy link
Member

I think the test repo needs to be updated as well, otherwise the state tests will fail

@jwasinger jwasinger mentioned this pull request Jan 6, 2025
Closed
@fjl
Copy link
Contributor

fjl commented Jan 14, 2025

Waiting for this issue to be resolved: ethereum/tests#1423

@s1na
Copy link
Contributor Author

s1na commented Jan 16, 2025

whatever happened to appveyor?!

@meyer9 meyer9 mentioned this pull request Jan 17, 2025
Open
1 task
MariusVanDerWijden
MariusVanDerWijden reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just noticed that there are a few test cases in the eip that we're missing: ethereum/EIPs@3bac186#diff-496e5bd975bb60ce623c764e96f7bb4c4e03385c707af558eaf45008c9ff6e7b
Would be great to add them as well

tests/state_test.go Show resolved Hide resolved
@s1na
Copy link
Contributor Author

s1na commented Jan 20, 2025

I just noticed that there are a few test cases in the eip that we're missing: ethereum/EIPs@3bac186#diff-496e5bd975bb60ce623c764e96f7bb4c4e03385c707af558eaf45008c9ff6e7b
Would be great to add them as well

Yep good idea. Added the EIP test cases in 👍

@s1na @MariusVanDerWijden
Update tests/state_test.go
3c6e89c 
Co-authored-by: Marius van der Wijden <[email protected]>
@fjl fjl added this to the 1.15.0 milestone Jan 24, 2025
@fjl fjl changed the title Core: EIP-2537 spec updates core/vm: EIP-2537 spec updates Jan 24, 2025
@fjl fjl changed the title core/vm: EIP-2537 spec updates core/vm: implement EIP-2537 spec updates Jan 24, 2025
@fjl fjl merged commit 3003a13 into ethereum:master Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden left review comments

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

Assignees
No one assigned
Labels
prague
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@s1na @MariusVanDerWijden @fjl @rjl493456442