-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-2537: Gas pricing MAP, MUL and ADD operations #9097
Conversation
✅ All reviewers have approved. |
EIPS/eip-2537.md
Outdated
|
||
#### Fp2-to-G2 mapping operation | ||
|
||
Fp2 -> G2 mapping is `75000` gas | ||
Fp2 -> G2 mapping is `14055` gas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's put 15000 here as you have in your NUC benchmarks. This number of from my BLST benchmarks. Considering this was 5x higher originally and nobody complained...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to 17000 based on the feedback from @jwasinger
Signed-off-by: garyschulte <[email protected]>
👍 from besu, implementing these gas costs and benchmarking on a nuc 13: |
Signed-off-by: garyschulte <[email protected]>
On constantine, on a Ryzen 7840U (laptop Zen4 15W~28W, 2023). If needed, my lowest power PC that can run an Ethereum node (no Rpi4 anymore) has a i3-1220P (28W, 2021).
Before
After
gas schedule can easily be edited here https://github.com/mratsim/constantine/blob/7cffd2f/benchmarks/bench_eth_evm_precompiles.nim#L45-L61 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
* chore(tests): pairing ops gas pricing cf ethereum/EIPs#9098 * chore(tests): MAP, MUL & ADD gas pricing cf ethereum/EIPs#9097 * chore(tests): update G1/add G2 msm discount tables ethereum/EIPs#9116
Nethermind proposal of MUL and ADD operations. The speed of this precompile measured on Intel NUC 11 Intel Core i7-1165G7 and Nethermind client (EcRecover ~80 mgas/s). Full proposal: https://github.com/Marchhill/bls-precompile-benchmarks/blob/main/proposed-changes.md
ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS
--
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: