EIP-758 update #985
Merged
EIP-758 update #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change eth_newFilter with params=["ReturnData"] to eth_newReturnDataFilter to be consistent with rest of JSON-RPC api.
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
tinybike
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change eth_newFilter with params=["returnData"] to eth_newReturnDataFilter to be consistent with rest of JSON-RPC api.
This is the first and most straightforward of the modifications to EIP-758 I suggested in Issue #963. I've been in contact with both @tinybike (original EIP author) and @adisney (he's working on the Parity implementation of it, while I'm working on the Geth implementation) about this, and both are in support of it.