Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-758 update #985

Merged
merged 3 commits into from
Apr 12, 2018
Merged

EIP-758 update #985

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e54cab5
EIP-758 update
Apr 7, 2018
193ec09
Merge branch 'master' into master
Apr 7, 2018
cced8e5
Merge branch 'master' into master
Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions EIPS/eip-758.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ The caller receives notifications about their transactions' return data in two c
```

### Polling
Push notifications require full duplex connections (i.e., websocket or IPC). Instead of subscribing, callers using HTTP send an `eth_newFilter` request:
Push notifications require full duplex connections (i.e., websocket or IPC). Instead of subscribing, callers using HTTP send an `eth_newReturnDataFilter` request:

```json
{"jsonrpc": "2.0", "id": 1, "method": "eth_newFilter", "params": ["returnData"]}
{"jsonrpc": "2.0", "id": 1, "method": "eth_newReturnDataFilter"}
```

The Ethereum node responds with a filter ID:
Expand Down Expand Up @@ -86,7 +86,7 @@ The node responds with an array of transaction hashes and their corresponding re
}
```

All transactions submitted by the client that were sealed _after_ the initial `eth_newFilter` request are included in this array.
All transactions submitted by the client that were sealed _after_ the initial `eth_newReturnDataFilter` request are included in this array.


## Rationale
Expand Down