Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t8n: Include empty requests[Hash] in JSON output #1064

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Oct 29, 2024

Fixes #1062.

Two open items:
1/ the t8n.cpp code is quite rudimentary, but I don't want to overdo it, considering it's going to get an overhaul when implementing EIPs 7251/6110/7002. This is just enough to satisfy the t8n format required by EIP-7685
2/ I've spent a lot of time trying to find a CMakeLists setup that works. I have no idea if this is proper, I only superficially caught up with cmake docs. Also not sure if the proposed placement of sha256.xpp is OK.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.23%. Comparing base (dad97f6) to head (82c945b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   94.22%   94.23%   +0.01%     
==========================================
  Files         158      158              
  Lines       17066    17081      +15     
==========================================
+ Hits        16081    16097      +16     
+ Misses        985      984       -1     
Flag Coverage Δ
eof_execution_spec_tests 17.79% <0.00%> (-0.02%) ⬇️
ethereum_tests 26.50% <0.00%> (-0.03%) ⬇️
ethereum_tests_silkpre 19.10% <0.00%> (-0.02%) ⬇️
execution_spec_tests 20.21% <0.00%> (-0.02%) ⬇️
unittests 89.29% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/t8n/t8n.cpp 87.79% <100.00%> (+1.80%) ⬆️

@pdobacz pdobacz force-pushed the t8n-eip-7682 branch 5 times, most recently from c573112 to 1d4994f Compare October 30, 2024 10:54
@pdobacz pdobacz marked this pull request as ready for review October 30, 2024 11:08
@pdobacz pdobacz requested a review from chfast October 30, 2024 11:09
Base automatically changed from eofsaka to master October 31, 2024 13:26
lib/crypto/CMakeLists.txt Outdated Show resolved Hide resolved
test/integration/t8n/CMakeLists.txt Outdated Show resolved Hide resolved
@pdobacz pdobacz merged commit 66216f9 into master Nov 4, 2024
25 checks passed
@pdobacz pdobacz deleted the t8n-eip-7682 branch November 4, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T8N updates for Prague Devnet-4 Changes
2 participants