-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t8n: Include empty requests[Hash] in JSON output #1064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdobacz
commented
Oct 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
+ Coverage 94.22% 94.23% +0.01%
==========================================
Files 158 158
Lines 17066 17081 +15
==========================================
+ Hits 16081 16097 +16
+ Misses 985 984 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pdobacz
force-pushed
the
t8n-eip-7682
branch
5 times, most recently
from
October 30, 2024 10:54
c573112
to
1d4994f
Compare
chfast
reviewed
Nov 4, 2024
chfast
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1062.
Two open items:
1/ the t8n.cpp code is quite rudimentary, but I don't want to overdo it, considering it's going to get an overhaul when implementing EIPs 7251/6110/7002. This is just enough to satisfy the t8n format required by EIP-7685
2/ I've spent a lot of time trying to find a CMakeLists setup that works. I have no idea if this is proper, I only superficially caught up with cmake docs. Also not sure if the proposed placement of sha256.xpp is OK.