Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t8n: Include empty requests[Hash] in JSON output - hardcoded #1065

Closed
wants to merge 2 commits into from

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Oct 29, 2024

Hardcoded version of #1064

Fixes #1062

If the sha256 refactor from #1064 is not useful, we can just roll with this

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.23%. Comparing base (39daf04) to head (cd8210c).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1065   +/-   ##
=======================================
  Coverage   94.22%   94.23%           
=======================================
  Files         158      158           
  Lines       17054    17059    +5     
=======================================
+ Hits        16069    16075    +6     
+ Misses        985      984    -1     
Flag Coverage Δ
eof_execution_spec_tests 17.81% <0.00%> (-0.01%) ⬇️
ethereum_tests 26.53% <0.00%> (-0.01%) ⬇️
ethereum_tests_silkpre 19.12% <0.00%> (-0.01%) ⬇️
execution_spec_tests 20.24% <0.00%> (-0.01%) ⬇️
unittests 89.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/t8n/t8n.cpp 87.03% <100.00%> (+1.04%) ⬆️

@pdobacz pdobacz force-pushed the t8n-eip-7685-hardcode branch from 9b377c9 to 17ba9bd Compare October 30, 2024 09:57
@pdobacz pdobacz marked this pull request as ready for review October 30, 2024 11:09
@pdobacz pdobacz requested a review from chfast October 30, 2024 11:09
Base automatically changed from eofsaka to master October 31, 2024 13:26
@pdobacz
Copy link
Contributor Author

pdobacz commented Nov 4, 2024

close in favor of the original #1064

@pdobacz pdobacz closed this Nov 4, 2024
@pdobacz pdobacz deleted the t8n-eip-7685-hardcode branch November 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T8N updates for Prague Devnet-4 Changes
1 participant