Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAINID opcode - 64 bit version #164

Closed
wants to merge 2 commits into from
Closed

CHAINID opcode - 64 bit version #164

wants to merge 2 commits into from

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 10, 2019

https://eips.ethereum.org/EIPS/eip-1344

Currently based on EVMC branch changing ChainID size to 64 bit ethereum/evmc#420

@gumb0 gumb0 force-pushed the chainid branch 2 times, most recently from 81f6f8f to 6873c12 Compare September 10, 2019 10:14
@codecov-io
Copy link

Codecov Report

Merging #164 into master will increase coverage by 0.64%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   84.61%   85.25%   +0.64%     
==========================================
  Files          21       21              
  Lines        2229     2232       +3     
  Branches      219      219              
==========================================
+ Hits         1886     1903      +17     
+ Misses        316      302      -14     
  Partials       27       27

@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6067254). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #164   +/-   ##
=========================================
  Coverage          ?   99.52%           
=========================================
  Files             ?        5           
  Lines             ?      842           
  Branches          ?      109           
=========================================
  Hits              ?      838           
  Misses            ?        1           
  Partials          ?        3

@gumb0
Copy link
Member Author

gumb0 commented Sep 18, 2019

Rebased.

Last commit adds Istanbul's opcode repricing to op_table, it should be better extracted to a separate PR.

@gumb0 gumb0 changed the title CHAINID opcode CHAINID opcode - 64 bit version Sep 24, 2019
@chfast
Copy link
Member

chfast commented Nov 12, 2019

Closing, because the 256-bit variant is only needed at the moment.

@chfast chfast closed this Nov 12, 2019
@axic axic deleted the chainid branch November 12, 2019 16:08
jwasinger pushed a commit to jwasinger/evmone that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants