CHAINID opcode - 256 bit version #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 839 842 +3
Branches 109 109
=====================================
+ Hits 839 842 +3 |
|
Do you want me to finish this one? |
|
@chfast sure go ahead |
chfast
force-pushed
the
chainid-256bit
branch
from
e757c35 to
aa7e019
Compare
Co-authored-by: Paweł Bylica <[email protected]>
chfast
force-pushed
the
chainid-256bit
branch
from
aa7e019 to
1213602
Compare
chfast
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a variant of CHAINID implementation that uses current EVMC
master, which defines chain ID asevmc_uint256beBased on separate PR that updates EVMC #189
A version that uses 64 bit chain ID was in #164