maxpeers reached and trusted-nodes.json ignored

[MysticRyuujin]

System information

Geth version: v1.6.1-stable-021c3c28 and v1.6.0-stable-facc47cb
OS & Version: Linux (Ubuntu 16.04) and Windows 10

Details

I have two computers running Geth

On both computers I have a static-nodes.json and a trusted-nodes.json file in the datadir and they contain one entry: the other node...

I am under the impression that placing a node into trusted-nodes.json would not count against the maxpeers? However, running Geth with default maxpeers (not specifying --maxpeers, which defaults to 25) results in the systems not connecting to each other when net.peerCount = 25 on one of the nodes.

If I were to restart the node with a peer count of 25 they'll connect to each other just fine. So it appears to me that the trusted-nodes.json is being ignored when default maxpeers is reached?

One node is v1.6.1-stable-021c3c28 and the other is v1.6.0-stable-facc47cb

I can reproduce at any time as one of my nodes is pretty much "public" over 30303 and always has 25 nodes, while the other does not...

This might be related to #3326

Expected behaviour

Nodes configured in trusted-nodes.json connect to each other regardless of the number of peers connected

Actual behaviour

Nodes configured in trusted-nodes.json only connect if current peer count is less than maxpeers

Steps to reproduce the behaviour

configure trusted-nodes.json on two systems
start one system and let it reach maxpeers (without the --maxpeers setting this is 25)
start the other system, they will not connect

[paulvi]

Where is documentation about trusted-nodes.json ?

• Commits like 62fc96620d864291dc56bae5568cbaa44714c19f should go with documentation updates.

Both resources do not mention about trusted-nodes:

• https://github.com/ethereum/homestead-guide/blob/master/source/network/connecting-to-the-network.rst#static-nodes-trusted-nodes-and-boot-nodes
• https://github.com/ethereum/go-ethereum/wiki/Connecting-to-the-network

[holiman]

Where is documentation about trusted-nodes.json ?

Here, it seems:
https://geth.ethereum.org/docs/interface/peer-to-peer#trusted-nodes