eth, les: Allow exceeding maxPeers for trusted peers #16189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shazow
force-pushed
the
fix-trusted-slots
branch
from
bc035dc to
62fc966
Compare
karalabe
requested changes
Feb 26, 2018
shazow
force-pushed
the
fix-trusted-slots
branch
from
62fc966 to
cfc4625
Compare
|
@karalabe forcepushed, PTAL. |
|
My pleasure! 🍮 |
prestonvanloon
pushed a commit
to prestonvanloon/go-ethereum
that referenced
this pull request
Apr 2, 2018
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trusted peers are supposed to be able to bypass the maxPeers limit. This logic was appropriately executed in p2p/server.go, but the eth handler and les handler also check maxPeers which were previously ignoring the trusted flag for peers.
I tested this locally with some empty blockchains (I'm on bad wifi, can't complete a sync right now), and the "too many peers" error did indeed go away after this fix.
Let me know if there is a good place to write a test for this, or if this is good enough as is (fairly simple change).
Fixes #3326, #14472