p2p: track goroutines with wg, fixes #20558 #20559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Jan 15, 2020
p2p/server.go
Outdated
| @@ -911,7 +911,9 @@ func (srv *Server) listenLoop() { | |||
| fd = newMeteredConn(fd, true, addr) | |||
| srv.log.Trace("Accepted connection", "addr", fd.RemoteAddr()) | |||
| } | |||
| srv.loopWG.Add(1) | |||
There was a problem hiding this comment.
Adding to loopWG from within the loop is unsafe because it can lead to Add being called concurrently with Wait. It would be better to wait for the slots channel on shutdown.
There was a problem hiding this comment.
Ok, I've squashed in an alternate solution, PTAL
|
Resubmitted as #20569 with the additional change of waiting for all slots instead of just one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #20558