Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: wait for listener goroutines on shutdown #20569

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Jan 16, 2020

Resubmit of #20559
Fixes #20558

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe added this to the 1.9.10 milestone Jan 16, 2020
@karalabe karalabe merged commit fcafa0b into ethereum:master Jan 16, 2020
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
* p2p: wait for goroutine exit, fixes ethereum#20558

* p2p: wait for all slots on exit

Co-authored-by: Martin Holst Swende <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis failure (internal/log)
3 participants