Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing Mnemonic #123

Merged
merged 31 commits into from
Nov 3, 2020
Merged

Existing Mnemonic #123

Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
1e9f50f
Adds language detection and verification of mnemonics
CarlBeek Aug 23, 2020
0e17266
Creates new_mnemonic cli options
CarlBeek Aug 24, 2020
0fd3c0b
Break new and existing mnemonics into separate files with generate_ke…
CarlBeek Sep 28, 2020
c7ec603
minor cleanups
CarlBeek Sep 28, 2020
d3a6f7d
Pass cli tests
CarlBeek Sep 29, 2020
1e04ab2
Linting is a thing
CarlBeek Sep 29, 2020
016d2c9
merge in dev and resolve conflicts
CarlBeek Oct 14, 2020
5d92936
Merge branch 'dev' into existing_mnemonic
CarlBeek Oct 20, 2020
4ff9f2a
Clarifies the dangers of mnemonic-passwords
CarlBeek Oct 20, 2020
3891cba
Apply suggestions from code review
CarlBeek Oct 21, 2020
52b36bc
Fix indentation error
CarlBeek Oct 26, 2020
633409c
Implement @hwwhww's code review suggestions
CarlBeek Oct 26, 2020
f4d7341
Adds tests for both new and existing mnemonics via CLI
CarlBeek Oct 28, 2020
ffcbfbc
Adds new-mnemonic and existing-mnemonic commands to README
CarlBeek Oct 30, 2020
014e34c
Merge in dev
CarlBeek Nov 2, 2020
2d0813b
Fix Makefile and Dockerfile
hwwhww Nov 3, 2020
ad5b96e
Update README
hwwhww Nov 3, 2020
fe5b539
Merge pull request #139 from ethereum/existing_mnemonic-fix_dockerfile
CarlBeek Nov 3, 2020
741fa62
Fix CLI index bounds
CarlBeek Nov 3, 2020
29f0089
Re-adds password length checks from #138 which were accidentally remo…
CarlBeek Nov 3, 2020
07dce72
remove reference to "withdrawal keys"
CarlBeek Nov 3, 2020
d3149c6
Update help messages for all CLI arguments and commands
CarlBeek Nov 3, 2020
10bc333
Apply @hwwhww's README simplifications
CarlBeek Nov 3, 2020
6f54965
Add test_regeneration.py
hwwhww Nov 3, 2020
1208820
Rename `test_deposit` test case to `test_existing_mnemonic`
hwwhww Nov 3, 2020
28d8a36
Merge branch 'dev' into existing_mnemonic
hwwhww Nov 3, 2020
8c642d6
Fix typo
hwwhww Nov 3, 2020
fb49865
Update tests/test_cli/test_regeneration.py
hwwhww Nov 3, 2020
eb37e12
Apply suggestions from code review
hwwhww Nov 3, 2020
c853942
Merge pull request #143 from ethereum/existing_mnemonic-test_regenera…
CarlBeek Nov 3, 2020
45b2387
Merge in dev and resolve conflicts
CarlBeek Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,8 @@ RUN pip3 install -r requirements.txt

RUN python3 setup.py install

ARG cli_command

ENTRYPOINT [ "python3", "./eth2deposit/deposit.py" ]

CMD [ $cli_command ]
5 changes: 2 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ venv_lint: venv_build_test
$(VENV_ACTIVATE) && flake8 --config=flake8.ini ./eth2deposit ./tests && mypy --config-file mypy.ini -p eth2deposit

venv_deposit: venv_build
$(VENV_ACTIVATE) && python ./eth2deposit/deposit.py
$(VENV_ACTIVATE) && python ./eth2deposit/deposit.py $(filter-out $@,$(MAKECMDGOALS))

build_macos: venv_build
${VENV_NAME}/bin/python -m pip install -r ./build_configs/macos/requirements.txt
Expand All @@ -57,5 +57,4 @@ build_docker:
@docker build --pull -t $(DOCKER_IMAGE) .

run_docker:
@docker run -it --rm $(DOCKER_IMAGE)

@docker run -it --rm $(DOCKER_IMAGE) $(filter-out $@,$(MAKECMDGOALS))
Loading