Existing Mnemonic #123

CarlBeek · 2020-09-29T14:29:58Z

Adds support for existing mnemonics (with automatic language detection) and deriving keys from a non-0 index to start.

#94 and #122 are others' attempts at this, but former doesn't check the mnemonic and the latter doesn't offer start-indices.

…ys subcommand

unexpectedbit · 2020-09-30T23:37:18Z

It generates different keys when inputting the mnemonic phrase (with no password) that was generated using the existing tool from master branch.

torfbolt · 2020-10-04T12:18:17Z

@unexpectedbit did you compare to keys generated with the current master, or with a previous master? Afaik there were recent changes to the key derivation algorithm, so old keys might not be reproducible even without this PR.

unexpectedbit · 2020-10-06T21:36:45Z

After manually modifying the master branch files with changes from this pull request, the correct (same) keys are generated!

duelinggalois · 2020-10-10T04:04:37Z

This may be due to the changes to the key derivation algorithm mentioned above, but I was unable to create the same keys, I was however able to do so using the fork that @torfbolt created.

unexpectedbit · 2020-10-10T10:16:17Z

@rev3ks Did you try generating the keys using the "existing_mnemonic" branch files or did you modify "master" branch files with code changes from this PR? I think that the rest of code in files of "existing_mnemonic" branch is obsolete and therefore generates different keys.

duelinggalois · 2020-10-10T15:00:15Z

I used this branch not master and ran ./deposit.sh existing-mnemonic --mnemonic "..." --num_validators 1 --chain medalla, the public key was the same, but the signature and withdraw_credentials did not.

* dev: Clean checksum output Special snowflake native shasum for macos Persist envars by making them a part of the pyinstaller process in makefile Add Windows build SHA1 -> SHA256 Revert, the 2nd revert change on venv activation Adds SHA256 checksums to circleci and makes builds determanistic.

hwwhww

My first pass. 👀 Good job!

eth2deposit/cli/existing_mnemonic.py

eth2deposit/key_handling/key_derivation/mnemonic.py

tests/test_cli.py

tests/test_key_handling/test_key_derivation/test_mnemonic.py

eth2deposit/credentials.py

eth2deposit/cli/new_mnemonic.py

Co-authored-by: Hsiao-Wei Wang <[email protected]>

fabdarice · 2020-10-29T15:07:59Z

I was not able to re-generate the same public keys using the seed.
To be fair, I remember generating those prior to medalla launch so it's been a while ago..

hwwhww · 2020-11-01T11:59:12Z

@fabdarice

The BLS library version was IETF draft 02 when Medalla was launched, but now it's IETF BLS draft 04. Unfortunately, the KeyGen algorithm was changed when 02->04 so you're unable to use this PR to re-generate the early Medalla keys. 😢

The IETF BLS draft 04 will be the BLS version for phase 0 launch. You can also use it to re-generate the Zinken testnet keys.

Sorry for the confusion!

fabdarice · 2020-11-01T13:19:20Z

@fabdarice

The BLS library version was IETF draft 02 when Medalla was launched, but now it's IETF BLS draft 04. Unfortunately, the KeyGen algorithm was changed when 02->04 so you're unable to use this PR to re-generate the early Medalla keys.

The IETF BLS draft 04 will be the BLS version for phase 0 launch. You can also use it to re-generate the Zinken testnet keys.

Sorry for the confusion!

Yep, saw that. No problem. This PR will come in handy for those who lost their validator keys.

hwwhww

Some missing code during resolving commit conflicts.
Fix Dockerfile and Makefile in #123 #139 fixes the Dockerfile and Makefile

README.md

eth2deposit/cli/generate_keys.py

eth2deposit/cli/existing_mnemonic.py

eth2deposit/cli/generate_keys.py

Fix Dockerfile and Makefile in #123

`type=click.IntRange(0, 2**32)` got corrected to `type=click.IntRange(0, 2**32 - 1)` Co-authored-by: Hsiao-Wei Wang <[email protected]>

…ved in merge 014e34c

README.md

eth2deposit/cli/existing_mnemonic.py

hwwhww

I pushed some minor fixes her and it LGTM 👍

#143 added the cli key regeneration test case.

Co-authored-by: Carl Beekhuizen <[email protected]>

…tion Add cli test_regeneration

antliv · 2021-11-04T13:04:56Z

U burnt me

…ockerfile Fix Dockerfile and Makefile in ethereum#123

Existing Mnemonic

CarlBeek added 6 commits August 23, 2020 18:04

Adds language detection and verification of mnemonics

1e9f50f

Creates new_mnemonic cli options

0e17266

Break new and existing mnemonics into separate files with generate_ke…

0fd3c0b

…ys subcommand

minor cleanups

c7ec603

Pass cli tests

d3a6f7d

Linting is a thing

1e04ab2

CarlBeek changed the base branch from master to dev October 1, 2020 08:30

torfbolt mentioned this pull request Oct 3, 2020

Support generating more keys from the same mnemonic #29

Closed

CarlBeek added 3 commits October 14, 2020 17:29

merge in dev and resolve conflicts

016d2c9

Clarifies the dangers of mnemonic-passwords

4ff9f2a

hwwhww mentioned this pull request Oct 21, 2020

Add password length validation - take 2 #138

Merged

CarlBeek marked this pull request as ready for review October 21, 2020 12:46

hwwhww reviewed Oct 21, 2020

View reviewed changes

CarlBeek and others added 3 commits October 21, 2020 16:32

Apply suggestions from code review

3891cba

Co-authored-by: Hsiao-Wei Wang <[email protected]>

Fix indentation error

52b36bc

Implement @hwwhww's code review suggestions

633409c

hwwhww mentioned this pull request Oct 27, 2020

Add Docker image #65

Merged

Adds tests for both new and existing mnemonics via CLI

f4d7341

Adds new-mnemonic and existing-mnemonic commands to README

ffcbfbc

Merge in dev

014e34c

hwwhww added 2 commits November 3, 2020 14:28

Fix Makefile and Dockerfile

2d0813b

Update README

ad5b96e

hwwhww requested changes Nov 3, 2020

View reviewed changes

README.md Show resolved Hide resolved

eth2deposit/cli/generate_keys.py Outdated Show resolved Hide resolved

eth2deposit/cli/existing_mnemonic.py Outdated Show resolved Hide resolved

eth2deposit/cli/generate_keys.py Outdated Show resolved Hide resolved

CarlBeek and others added 4 commits November 3, 2020 12:20

Merge pull request #139 from ethereum/existing_mnemonic-fix_dockerfile

fe5b539

Fix Dockerfile and Makefile in #123

Fix CLI index bounds

741fa62

`type=click.IntRange(0, 2**32)` got corrected to `type=click.IntRange(0, 2**32 - 1)` Co-authored-by: Hsiao-Wei Wang <[email protected]>

Re-adds password length checks from #138 which were accidentally remo…

29f0089

…ved in merge 014e34c

remove reference to "withdrawal keys"

07dce72

hwwhww reviewed Nov 3, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

CarlBeek added 2 commits November 3, 2020 15:43

Update help messages for all CLI arguments and commands

d3149c6

Apply @hwwhww's README simplifications

10bc333

CarlBeek requested a review from hwwhww November 3, 2020 16:53

hwwhww added 3 commits November 4, 2020 02:05

Add test_regeneration.py

6f54965

Rename test_deposit test case to test_existing_mnemonic

1208820

Merge branch 'dev' into existing_mnemonic

28d8a36

hwwhww reviewed Nov 3, 2020

View reviewed changes

eth2deposit/cli/existing_mnemonic.py Outdated Show resolved Hide resolved

Fix typo

8c642d6

hwwhww approved these changes Nov 3, 2020

View reviewed changes

hwwhww and others added 4 commits November 4, 2020 02:33

Update tests/test_cli/test_regeneration.py

fb49865

Apply suggestions from code review

eb37e12

Co-authored-by: Carl Beekhuizen <[email protected]>

Merge pull request #143 from ethereum/existing_mnemonic-test_regenera…

c853942

…tion Add cli test_regeneration

Merge in dev and resolve conflicts

45b2387

CarlBeek merged commit 2d434a3 into dev Nov 3, 2020

CarlBeek mentioned this pull request Nov 3, 2020

[Generator] start_index & seed_phrase options #94

Closed

hwwhww mentioned this pull request Nov 3, 2020

dev->master #145

Merged

hwwhww mentioned this pull request Mar 25, 2021

Regenerate keys from mnemonic #80

Closed

CarlBeek deleted the existing_mnemonic branch March 16, 2022 11:18

everhusk pushed a commit to earthbitcoin/earth-wallet-cli that referenced this pull request Aug 3, 2023

Merge pull request ethereum#139 from ethereum/existing_mnemonic-fix_d…

603e808

…ockerfile Fix Dockerfile and Makefile in ethereum#123

everhusk pushed a commit to earthbitcoin/earth-wallet-cli that referenced this pull request Aug 3, 2023

Merge pull request ethereum#123 from ethereum/existing_mnemonic

940b6c2

Existing Mnemonic

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Existing Mnemonic #123

Existing Mnemonic #123

CarlBeek commented Sep 29, 2020

unexpectedbit commented Sep 30, 2020

torfbolt commented Oct 4, 2020

unexpectedbit commented Oct 6, 2020 •

edited

Loading

duelinggalois commented Oct 10, 2020

unexpectedbit commented Oct 10, 2020

duelinggalois commented Oct 10, 2020 •

edited

Loading

hwwhww left a comment

fabdarice commented Oct 29, 2020

hwwhww commented Nov 1, 2020

fabdarice commented Nov 1, 2020

hwwhww left a comment

hwwhww left a comment

antliv commented Nov 4, 2021

Existing Mnemonic #123

Existing Mnemonic #123

Conversation

CarlBeek commented Sep 29, 2020

unexpectedbit commented Sep 30, 2020

torfbolt commented Oct 4, 2020

unexpectedbit commented Oct 6, 2020 • edited Loading

duelinggalois commented Oct 10, 2020

unexpectedbit commented Oct 10, 2020

duelinggalois commented Oct 10, 2020 • edited Loading

hwwhww left a comment

Choose a reason for hiding this comment

fabdarice commented Oct 29, 2020

hwwhww commented Nov 1, 2020

fabdarice commented Nov 1, 2020

hwwhww left a comment

Choose a reason for hiding this comment

hwwhww left a comment

Choose a reason for hiding this comment

antliv commented Nov 4, 2021

unexpectedbit commented Oct 6, 2020 •

edited

Loading

duelinggalois commented Oct 10, 2020 •

edited

Loading