-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password length validation - take 2 #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a better solution overall than the one presented in #118. 👍
I do with the order was verify length then check for matching passwords, but this may be an example of perfect being the enemy of the good.
edited PR description: #118: |
* [WIP] Add password length validation * Workaround: use click callback function * Minor rewording
…lly removed in merge 014e34c
Address #99
Replace #118
I haven't figured out how to test hidden input (password) with the test script, but #123 gave me a hint of utilizing click callback function. This is a workaround of #118.
Example output
Compare with #118
--password
flag is disallowed--password
flag is allowedI do want to avoid (1), but (1) helps us writing the test script. 😓