Add Docker image

[mgcrea]

Adds a working Dockerfile to generate a ready to use Docker image.

Ideally you would have a CI job that does build the image and push automatically on success. If interested I could send another PR doing just that using GitHub actions / CircleCI.

[hwwhww]

Hi @mgcrea! It looks good and addresses #22. 👍
Do you mind changing the target branch to dev?

[mgcrea]

@hwwhww thanks! Just changed the target branch, looks like there is no conflicts.

[ltfschoen]

How about a .dockerignore file

# Prevent your local modules and debug logs from being
# copied onto your Docker image and possibly overwriting
# modules installed within your image
.git
__pycache__

[mgcrea]

@ltfschoen Thanks for the review+suggestions, just pushed a new commit including them. Also properly switched to the dev branch so the PR contains a single commit.

[PandaWhisperer]

Just spent the better part of an hour trying to make a Dockerfile myself. Finally got it working, then I come here to see that someone already thought of it... 😅

Also, this version is probably better because it produces a smaller image (mine was almost 1GB because I didn't know the right packages to install, so I used buster instead of alpine).

Just tested this PR and seems to work fine for me.

[ltfschoen]

Another useful resource is this https://github.com/stefa2k/prysm-docker-compose.

Note that I've also created a PR in this repo showing how I went about setting it all up myself.

[PandaWhisperer]

@ltfschoen that setup is what I use to run my validators for Medalla and also the reason why I wanted to dockerize the deposit CLI.

Stefan has done a great job making the key import as simple as possible, but it still took a bit of work to get the deposit CLI working, so I thought if only there was a docker image for that, this could literally become a one stop shop for setting up a validator, no futzing around with different compilers etc. required.

Unfortunately I did not find your PR there, @ltfschoen?

@mgcrea I think one improvement that would be nice to have would be a smaller image size. Yours was 264 MB, which is already a huge improvement over my 957, but I think it could be trimmed down quite a bit using a multi-stage build, which could basically drop the compiler and devtools required for the build process and only contain what's necessary to run the actual CLI.

I tried my hand at that, but unfortunately I failed, because my image did not include the compiled eggs, so it wouldn't run.

EDIT: after a few more experiments, victory is mine! I added the following lines to the Dockerfile, just before the ENTRYPOINT directive:

FROM python:3.7-alpine

COPY --from=0 /app /app
COPY --from=0 /usr/local /usr/local

WORKDIR /app

Basically, this creates a fresh image starting over with the same base, copies the app and the installed Python modules over, and packages that as a runtime image. I ran the CLI and it seemed to be able to generate a key successfully, and the image size went down to about 120 MB.

I think this could still go down quite a bit, after all the binary distribution is only about 14 MB zipped. I also tried to make an image just for that, but I couldn't get it to work. However, the image was only 22 MB large, which would be another great improvement.

[ltfschoen]

@PandaWhisperer FYI this is the PR with what I did #83

[PandaWhisperer]

@ltfschoen oh okay, I misunderstood you then. I thought you made a PR on stefa2k/prysm-docker-compose.

[mgcrea]

Is there anything left I can do to help this being merged? Thanks!

[raunchy-mx]

I don’t see anything necessary. Thanks

…

On Thu, Aug 20, 2020 at 10:33 PM Olivier Louvignes ***@***.***> wrote: Is there anything left I can do to help this being merged? Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE6WV4WCHHUWXQ7DZBKDHQDSBXTIDANCNFSM4PJAPPHA> .

[hwwhww]

Since we (EF) may not upload the docker image somewhere officially, I assume that the users have to build the docker image by themselves. That is, we probably should tell them how to build it in the document.

Otherwise, this PR looks good to me. Thank you! 😊

/cc @CarlBeek

[hwwhww]

Should the docs tell the user to build the docker image first? (make build_docker)

[hwwhww]

Hey @mgcrea 👋 are you still working on it?

[mgcrea]

Hey @hwwhww, yes will gladly add any changes required for this to land. I've added the make build_docker step.

[hwwhww]

LGTM!

/cc @CarlBeek would you like to take a look at it before merge?

[CarlBeek]

Looks good to me too. Thanks for your work on this @mgcrea!

[hwwhww]

Thank you @mgcrea!

Ideally you would have a CI job that does build the image and push automatically on success. If interested I could send another PR doing just that using GitHub actions / CircleCI.

Would you like to help with the CI job? #123 will change the command line interface so we should have dockerfile build in CI.