Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Path as argument to IPCProvider constructor #867

Closed
carver opened this issue May 29, 2018 · 0 comments · Fixed by #921
Closed

Accept Path as argument to IPCProvider constructor #867

carver opened this issue May 29, 2018 · 0 comments · Fixed by #921
Labels
Good First Issue

Comments

@carver
Copy link
Collaborator

carver commented May 29, 2018

What was wrong?

Currently, IPCProvider only accepts a str as the ipc path.

How can it be fixed?

Detect if the ipc_path is a pathlib.Path, and convert to str.
@veox veox mentioned this issue May 30, 2018
Closed
@pipermerriam pipermerriam mentioned this issue May 30, 2018
Merged
cryptomental added a commit to cryptomental/web3.py that referenced this issue Jun 22, 2018
@cryptomental
IPCProvider: Accept pathlib.Path in constructor.
dc5545a 
If ipc_path is an instance of pathlib.Path, resolve the path
and cast to string. Modify IPCProvider sync test to use pathlib
Path.

Fixes: ethereum#867
This was referenced Jun 22, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IPCProvider: Accept pathlib.Path in constructor. cryptomental/web3.py
1 participant
@carver