IPCProvider: Accept pathlib.Path in constructor. #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ipc_path is an instance of pathlib.Path, resolve the path and cast to string. Modify IPCProvider sync test to use pathlib Path. Fixes: ethereum#867
pipermerriam
approved these changes
Jun 22, 2018
|
Thank you for the approval! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
IPCProvider accepted only str paths.
How was it fixed?
If ipc_path is an instance of pathlib.Path, resolve the path
and cast to string. Modify IPCProvider sync test to use pathlib
Path.
Cute Animal Picture
Fixes: #867