Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e test for L2 Blob #142

Merged
merged 8 commits into from
Dec 27, 2024
Merged

e2e test for L2 Blob #142

merged 8 commits into from
Dec 27, 2024

Conversation

ping-ke
Copy link

@ping-ke ping-ke commented Dec 23, 2024 •
edited
Loading

Description
This PR address the issue(#102) of L2 Blob's E2E tests
For related manual step, see Test L2 BLOB at https://perfect-amphibian-929.notion.site/SWC-Devnet-1282e493e88380648486d4961eb91a8d

Tests

cd op-e2e
make devnet-allocs
go test -run '^(TestSubmitTXWithBlobsFunctionSuccess)$' github.com/ethereum-optimism/optimism/op-e2e/blobs  -count=1 -v

Questions

Should we add a test case for using SGT as the gas fee to send TX with blobs?

blockchaindevsh
blockchaindevsh reviewed Dec 24, 2024
View reviewed changes
op-e2e/faultproofs/util.go Outdated Show resolved Hide resolved
op-e2e/faultproofs/util.go Outdated Show resolved Hide resolved
op-e2e/faultproofs/util.go Outdated Show resolved Hide resolved
op-e2e/system/e2esys/setup.go Outdated Show resolved Hide resolved
@ping-ke ping-ke mentioned this pull request Dec 24, 2024
Closed
syntrust
syntrust reviewed Dec 24, 2024
View reviewed changes
op-e2e/blobs/blob_test.go Outdated Show resolved Hide resolved
op-e2e/blobs/blob_test.go Outdated Show resolved Hide resolved
op-node/rollup/types.go Outdated Show resolved Hide resolved
@ping-ke ping-ke requested a review from syntrust December 26, 2024 01:40
blockchaindevsh
blockchaindevsh approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@blockchaindevsh blockchaindevsh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the last two comments are resolved.

@ping-ke ping-ke merged commit 9d72b4a into op-es Dec 27, 2024
@ping-ke ping-ke deleted the es-e2e-blob branch December 27, 2024 01:56
This was referenced Dec 28, 2024
Closed
Merged
@ping-ke ping-ke mentioned this pull request Dec 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockchaindevsh blockchaindevsh blockchaindevsh approved these changes

@syntrust syntrust syntrust approved these changes

@qizhou qizhou Awaiting requested review from qizhou

@qzhodl qzhodl Awaiting requested review from qzhodl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ping-ke @syntrust @blockchaindevsh