Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: go-tests/fix dac url config #149

Merged
merged 2 commits into from
Jan 2, 2025
Merged

CircleCI: go-tests/fix dac url config #149

merged 2 commits into from
Jan 2, 2025

Conversation

syntrust
Copy link

Fix error:

dac.urls must be set for sequencer when l2 blob time is set

@blockchaindevsh
Copy link
Collaborator

Should we disable l2blob in e2e test by default, and enable it explicitly if we want to test it?

Then the test here should be the only one that has l2blob enabled.

@qzhodl
Copy link

qzhodl commented Dec 30, 2024

Should we disable l2blob in e2e test by default, and enable it explicitly if we want to test it?

Then the test here should be the only one that has l2blob enabled.

Same concern

@syntrust
Copy link
Author

Should we disable l2blob in e2e test by default, and enable it explicitly if we want to test it?

Then the test here should be the only one that has l2blob enabled.

How to disable the test? The problem is a lot of tests cannot pass the check here.

@blockchaindevsh
Copy link
Collaborator

Should we disable l2blob in e2e test by default, and enable it explicitly if we want to test it?
Then the test here should be the only one that has l2blob enabled.

How to disable the test? The problem is a lot of tests cannot pass the check here.

Explicitly disable l2 blob here?

Just ensure it's on for our own l2blob e2e test.

@blockchaindevsh
Copy link
Collaborator

Are those tests passing after this change?

@syntrust
Copy link
Author

syntrust commented Jan 2, 2025

Are those tests passing after this change?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants