Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: fix go-tests / TestOPCMLiveChain/sepolia/sepolia-v1.8.0-rc.3 #143

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

syntrust
Copy link

Error log:

        proxy.go:82:                INFO [12-23|06:51:58.333] server started                           module=retryproxy port=43673
        proxy.go:172:               WARN [12-23|06:51:58.422] unexpected status code                   module=retryproxy status=415
        proxy.go:121:               WARN [12-23|06:51:58.422] failed to proxy request                  module=retryproxy err="unexpected status code: 415"
        proxy.go:172:               WARN [12-23|06:51:59.862] unexpected status code                   module=retryproxy status=415
        proxy.go:121:               WARN [12-23|06:51:59.863] failed to proxy request                  module=retryproxy err="unexpected status code: 415"
        proxy.go:172:               WARN [12-23|06:52:02.400] unexpected status code                   module=retryproxy status=415
        proxy.go:121:               WARN [12-23|06:52:02.400] failed to proxy request                  module=retryproxy err="unexpected status code: 415"
        proxy.go:172:               WARN [12-23|06:52:06.944] unexpected status code                   module=retryproxy status=415
        proxy.go:121:               WARN [12-23|06:52:06.944] failed to proxy request                  module=retryproxy err="unexpected status code: 415"
        proxy.go:172:               WARN [12-23|06:52:12.064] unexpected status code                   module=retryproxy status=415
        proxy.go:121:               WARN [12-23|06:52:12.064] failed to proxy request                  module=retryproxy err="unexpected status code: 415"
        proxy.go:135:               ERROR[12-23|06:52:12.064] permanently failed to proxy request      module=retryproxy err="operation failed permanently after 5 attempts: unexpected status code: 415"
        anvil.go:113:               DEBUG[12-23|06:52:12.064] [ANVIL] thread 'main' panicked at /home/runner/work/foundry/foundry/crates/anvil/src/config.rs:1147:57:
        anvil.go:113:               DEBUG[12-23|06:52:12.064] [ANVIL] Failed to get fork block number: Transport(HttpError(HttpError { status: 502, body: "failed to proxy request\n" }))
        anvil.go:113:               DEBUG[12-23|06:52:12.064] "[ANVIL] note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace"
        opcm_test.go:63: 
                Error Trace:    /root/dl/circleci/optimism/op-deployer/pkg/deployer/bootstrap/opcm_test.go:63
/root/dl/circleci/optimism/op-deployer/pkg/deployer/bootstrap/opcm_test.go:33
                Error:          Received unexpected error:
                                context deadline exceeded
                Test:           TestOPCMLiveChain/sepolia-v1.8.0-rc.3

Status code 415 means "Unsupported Media Type" and "http://88.99.30.186:8545" looks cannot handle request without a specified content-type.

CircleCI tests passed with the fix in the latest run.

@dajuguan
Copy link

Can we reuse context to set the SEPOLIA_RPC_URL env?

@syntrust
Copy link
Author

Can we reuse context to set the SEPOLIA_RPC_URL env?

I'm not certain why Shell is being embedded instead of utilizing a context, but it might be related to the <<parameters.environment_overrides>> section below, and any changes could affect other jobs using this part. So I would prefer to maintain the current approach until necessary.

@@ -162,6 +162,7 @@ func (p *RetryProxy) doProxyReq(ctx context.Context, body []byte) (*http.Respons
if err != nil {
panic(fmt.Errorf("failed to create request: %w", err))
}
req.Header.Set("Content-Type", "application/json")
Copy link
Collaborator

@blockchaindevsh blockchaindevsh Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't upstream have this issue, are we using the same l1 client as upstream? We can upstream this fix if we know the root reason.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be the different implementation/configuration on the L1 clients.

@dajuguan
Copy link

Can we reuse context to set the SEPOLIA_RPC_URL env?

I'm not certain why Shell is being embedded instead of utilizing a context, but it might be related to the <<parameters.environment_overrides>> section below, and any changes could affect other jobs using this part. So I would prefer to maintain the current approach until necessary.

I see. The concern is that our RPC could be exposed to malicious actors, which is why I inquired about it earlier.

@syntrust
Copy link
Author

Can we reuse context to set the SEPOLIA_RPC_URL env?

I'm not certain why Shell is being embedded instead of utilizing a context, but it might be related to the <<parameters.environment_overrides>> section below, and any changes could affect other jobs using this part. So I would prefer to maintain the current approach until necessary.

I see. The concern is that our RPC could be exposed to malicious actors, which is why I inquired about it earlier.

Yes, that is a concern, especially if we need to replace the mainnet RPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants