-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI: fix go-tests / TestOPCMLiveChain/sepolia/sepolia-v1.8.0-rc.3 #143
Conversation
Can we reuse context to set the |
I'm not certain why Shell is being embedded instead of utilizing a context, but it might be related to the |
@@ -162,6 +162,7 @@ func (p *RetryProxy) doProxyReq(ctx context.Context, body []byte) (*http.Respons | |||
if err != nil { | |||
panic(fmt.Errorf("failed to create request: %w", err)) | |||
} | |||
req.Header.Set("Content-Type", "application/json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't upstream have this issue, are we using the same l1 client as upstream? We can upstream this fix if we know the root reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be the different implementation/configuration on the L1 clients.
I see. The concern is that our RPC could be exposed to malicious actors, which is why I inquired about it earlier. |
Yes, that is a concern, especially if we need to replace the mainnet RPC. |
Error log:
Status code 415 means "Unsupported Media Type" and "http://88.99.30.186:8545" looks cannot handle request without a specified content-type.
CircleCI tests passed with the fix in the latest run.