Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: fix go-tests / TestOPCMLiveChain/sepolia/sepolia-v1.8.0-rc.3 #143

Merged
merged 2 commits into from
Dec 25, 2024
Merged

CircleCI: fix go-tests / TestOPCMLiveChain/sepolia/sepolia-v1.8.0-rc.3 #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f06eecc
fix unexpected status code: 415
syntrust Dec 24, 2024
14a7816
update rpc
syntrust Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,7 @@ jobs:
export OP_E2E_SKIP_SLOW_TEST=true
export OP_E2E_USE_HTTP=true
export ENABLE_ANVIL=true
export SEPOLIA_RPC_URL="https://ci-sepolia-l1-archive.optimism.io"
export SEPOLIA_RPC_URL="http://88.99.30.186:8545"
export MAINNET_RPC_URL="https://ci-mainnet-l1-archive.optimism.io"

<<parameters.environment_overrides>>
Expand Down
1 change: 1 addition & 0 deletions op-e2e/e2eutils/retryproxy/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ func (p *RetryProxy) doProxyReq(ctx context.Context, body []byte) (*http.Respons
if err != nil {
panic(fmt.Errorf("failed to create request: %w", err))
}
req.Header.Set("Content-Type", "application/json")
Copy link
Collaborator

@blockchaindevsh blockchaindevsh Dec 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't upstream have this issue, are we using the same l1 client as upstream? We can upstream this fix if we know the root reason.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be the different implementation/configuration on the L1 clients.

res, err := p.client.Do(req)
if err != nil {
p.lgr.Warn("failed to proxy request", "err", err)
Expand Down