Set default ports for dev scripts on admin-ui and privacy center #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #7889 ↗︎
Details:
Review all test suite changes for PR #4912 ↗︎ |
||||||||||||||||||||
| @@ -12,7 +12,7 @@ | |||
| "cy:open": "cypress open", | |||
| "cy:run": "cypress run", | |||
| "cy:start": "NODE_ENV=test next build && NODE_ENV=test next start", | |||
| "dev": "next dev", | |||
| "dev": "next dev -p 3000", | |||
andres-torres-marroquin
approved these changes
May 23, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Set default ports for dev scripts on admin-ui and privacy center. The existing problem is that when running turbo run dev, it becomes a race-condition for the port assignment between admin-ui and privacy-center. This would solve the issue. Only making the change on the dev scripts to avoid conflicting with CI scripts.
Code Changes
Pre-Merge Checklist
CHANGELOG.md