Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default ports for dev scripts on admin-ui and privacy center #4912

Merged
merged 6 commits into from
May 23, 2024
Merged

Set default ports for dev scripts on admin-ui and privacy center #4912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0e3112
Set default ports for dev scripts on admin-ui and privacy center
May 22, 2024
2f18615
Merge branch 'main' of github.com:ethyca/fides into default-client-ports
May 22, 2024
8062aa3
Merge branch 'main' of github.com:ethyca/fides into default-client-ports
May 23, 2024
ec231a1
update changelog
May 23, 2024
d89e2b6
update changelog
May 23, 2024
12a8c2a
Merge branch 'main' of github.com:ethyca/fides into default-client-ports
May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ The types of changes are:

## [Unreleased](https://github.com/ethyca/fides/compare/2.37.0...main)

### Changed
- Set default ports for local development of client projects (:3001 for privacy center and :3000 for admin-ui) [#4912](https://github.com/ethyca/fides/pull/4912)


## [2.37.0](https://github.com/ethyca/fides/compare/2.36.0...2.37.0)

### Added
Expand Down
2 changes: 1 addition & 1 deletion clients/admin-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"cy:open": "cypress open",
"cy:run": "cypress run",
"cy:start": "NODE_ENV=test next build && NODE_ENV=test next start",
"dev": "next dev",
"dev": "next dev -p 3000",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

"dev:mock": "echo '🚨 Running with mock API'; NEXT_PUBLIC_MOCK_API=true next dev",
"export": "next build && next export",
"prod-export": "npm run export && npm run copy-export",
Expand Down
2 changes: 1 addition & 1 deletion clients/privacy-center/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "2.13.0",
"private": true,
"scripts": {
"dev": "next dev",
"dev": "next dev -p 3001",
"dev:windows": "next dev",
"build": "next build",
"start": "next start",
Expand Down
Loading